LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str); /sbbsecho.c: 2191 in areamgr_command()
2185 return true;
2186 }
2187
2188 if (strnicmp(instr, "PASSWORD ", 9) == 0 || strnicmp(instr, "PWD ", 4) == 0) {
2189 char password[FIDO_SUBJ_LEN]; /* AreaMgr password for this node */
2190 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2191 FIND_WHITESPACE(p);
2192 SKIP_WHITESPACE(p);
2193 SAFECOPY(password, p);
2194 if (strchr(password, ' ') != NULL) {
2195 snprintf(str, sizeof str, "Your AreaMgr password cannot contain spaces.");
2196 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2224 in areamgr_command()
2218 return true;
2219 }
2220
2221 if (strnicmp(instr, "PKTPWD ", 7) == 0) {
2222 char pktpwd[FIDO_PASS_LEN + 1]; /* Packet password for this node */
2223 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2224 FIND_WHITESPACE(p);
2225 SKIP_WHITESPACE(p);
2226 SAFECOPY(pktpwd, p);
2227 if (!stricmp(pktpwd, nodecfg->pktpwd)) {
2228 snprintf(str, sizeof str, "Your packet password was already set to '%s'."
2229 , nodecfg->pktpwd);
/sbbsecho.c: 2335 in areamgr_command()
2329 , str, /* dest: */ addr, /* src: */ NULL);
2330 return true;
2331 }
2332
2333 if (strnicmp(instr, "ECHOSTATS ", 10) == 0) {
2334 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2335 FIND_WHITESPACE(p);
2336 SKIP_WHITESPACE(p);
2337 echostat_t* stat = get_echostat(p, /* create: */ false);
2338 if (stat == NULL) {
2339 lprintf(LOG_INFO, "AreaMgr (for %s) EchoStats request for unknown echo: %s", faddrtoa(&addr), p);
2340 } else {
/sbbsecho.c: 2156 in areamgr_command()
2150 alter_config(nodecfg, "Name", to);
2151 }
2152
2153 if (strnicmp(instr, "COMPRESSION ", 12) == 0 || strnicmp(instr, "COMPRESS ", 9) == 0) {
2154 char* p = instr;
2155 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2156 SKIP_WHITESPACE(p);
2157 if (!stricmp(p, "NONE"))
2158 nodecfg->archive = SBBSECHO_ARCHIVE_NONE; 2159 else {
2160 for (u = 0; u < cfg.arcdefs; u++)
2161 if (stricmp(p, cfg.arcdef[u].name) == 0)
/sbbsecho.c: 2273 in areamgr_command()
2267 create_netmail(to, /* msg: */ NULL, "TIC File Password Change Request", str, /* dest: */ addr, /* src: */ NULL);
2268 return true;
2269 }
2270
2271 if (strnicmp(instr, "NOTIFY ", 7) == 0) {
2272 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2273 FIND_WHITESPACE(p);
2274 SKIP_WHITESPACE(p);
2275 if (alter_config(nodecfg, "Notify", p)) { 2276 SAFEPRINTF2(str, "Your Notification Messages have been changed from '%s' to '%s'."
2277 , nodecfg->send_notify ? "ON" : "OFF", p);
2278 } else {
/sbbsecho.c: 2192 in areamgr_command()
2186 }
2187
2188 if (strnicmp(instr, "PASSWORD ", 9) == 0 || strnicmp(instr, "PWD ", 4) == 0) {
2189 char password[FIDO_SUBJ_LEN]; /* AreaMgr password for this node */
2190 char* p = instr;
2191 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2192 SKIP_WHITESPACE(p);
2193 SAFECOPY(password, p);
2194 if (strchr(password, ' ') != NULL) {
2195 snprintf(str, sizeof str, "Your AreaMgr password cannot contain spaces.");
2196 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
2197 create_netmail(to, /* msg: */ NULL, "AreaMgr Password Change Request", str
/sbbsecho.c: 2336 in areamgr_command()
2330 return true;
2331 }
2332
2333 if (strnicmp(instr, "ECHOSTATS ", 10) == 0) {
2334 char* p = instr;
2335 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2336 SKIP_WHITESPACE(p);
2337 echostat_t* stat = get_echostat(p, /* create: */ false);
2338 if (stat == NULL) {
2339 lprintf(LOG_INFO, "AreaMgr (for %s) EchoStats request for unknown echo: %s", faddrtoa(&addr), p);
2340 } else {
2341 FILE* fp;
/sbbsecho.c: 2250 in areamgr_command()
2244 }
2245
2246 if (strnicmp(instr, "TICPWD ", 7) == 0) {
2247 char ticpwd[SBBSECHO_MAX_TICPWD_LEN + 1]; /* TIC File password for this node */
2248 char* p = instr;
2249 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2250 SKIP_WHITESPACE(p);
2251 SAFECOPY(ticpwd, p);
2252 if (!stricmp(ticpwd, nodecfg->ticpwd)) {
2253 snprintf(str, sizeof str, "Your TIC File password was already set to '%s'."
2254 , nodecfg->ticpwd);
2255 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2155 in areamgr_command()
2149 lprintf(LOG_INFO, "AreaMgr (for %s) Changing name to: %s", faddrtoa(&addr), to);
2150 alter_config(nodecfg, "Name", to);
2151 }
2152
2153 if (strnicmp(instr, "COMPRESSION ", 12) == 0 || strnicmp(instr, "COMPRESS ", 9) == 0) {
2154 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2155 FIND_WHITESPACE(p);
2156 SKIP_WHITESPACE(p);
2157 if (!stricmp(p, "NONE"))
2158 nodecfg->archive = SBBSECHO_ARCHIVE_NONE; 2159 else {
2160 for (u = 0; u < cfg.arcdefs; u++) /sbbsecho.c: 2274 in areamgr_command()
2268 return true;
2269 }
2270
2271 if (strnicmp(instr, "NOTIFY ", 7) == 0) {
2272 char* p = instr;
2273 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2274 SKIP_WHITESPACE(p);
2275 if (alter_config(nodecfg, "Notify", p)) { 2276 SAFEPRINTF2(str, "Your Notification Messages have been changed from '%s' to '%s'."
2277 , nodecfg->send_notify ? "ON" : "OFF", p);
2278 } else {
2279 SAFECOPY(str, "Error changing Notify Setting");
/sbbsecho.c: 2306 in areamgr_command()
2300 return true;
2301 }
2302
2303 // %RESCAN <area-tag> [R=<count> || D=<days>] 2304 if (strnicmp(instr, "RESCAN ", 7) == 0) {
2305 char* p = instr + 7;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2306 SKIP_WHITESPACE(p);
2307 char* tp = p;
2308 FIND_WHITESPACE(tp);
2309 if (*tp != '\0') {
2310 *tp = '\0';
2311 ++tp;
/sbbsecho.c: 2249 in areamgr_command()
2243 return true;
2244 }
2245
2246 if (strnicmp(instr, "TICPWD ", 7) == 0) {
2247 char ticpwd[SBBSECHO_MAX_TICPWD_LEN + 1]; /* TIC File password for this node */
2248 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2249 FIND_WHITESPACE(p);
2250 SKIP_WHITESPACE(p);
2251 SAFECOPY(ticpwd, p);
2252 if (!stricmp(ticpwd, nodecfg->ticpwd)) {
2253 snprintf(str, sizeof str, "Your TIC File password was already set to '%s'."
2254 , nodecfg->ticpwd);

** CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /main.cpp: 5749 in bbs_thread()


_____________________________________________________________________________________________
*** CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /main.cpp: 5749 in bbs_thread()
5743 /* ToDo: Make ident timeout configurable */
5744 if (identify(&client_addr, inet_addrport(&client_addr), str, sizeof(str) - 1, /* timeout: */ 1)) {
5745 lprintf(LOG_DEBUG, "%04d %s [%s] Ident Response: %s", client_socket, client.protocol, host_ip, str);
5746 identity = strrchr(str, ':');
5747 if (identity != NULL) {
5748 identity++; /* skip colon */
>>> CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*identity == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
5749 SKIP_WHITESPACE(identity);
5750 if (*identity)
5751 lprintf(LOG_INFO, "%04d %s [%s] Identity: %s", client_socket, client.protocol, host_ip, identity);
5752 }
5753 }
5754 sbbs->cp437_out(crlf);

** CID 641203: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 432 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
/netmail.cpp: 422 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()


_____________________________________________________________________________________________
*** CID 641203: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 432 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
426 SAFECOPY(to, p);
427 p += strlen(p) + 1;
428 continue;
429 }
430 if (strncmp(p, "Subject:", 8) == 0) {
431 p += 8;
>>> CID 641203: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
432 SKIP_WHITESPACE(p);
433 char* tp = strchr(p, QWK_NEWLINE); /* chop off at first CR */
434 if (tp != NULL)
435 *tp = 0;
436 subject = p;
437 p += strlen(p) + 1;
/netmail.cpp: 422 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
416 SAFECOPY(to, into);
417
418 // Parse QWKE Kludge Lines here:
419 while (p < end && *p != QWK_NEWLINE) {
420 if (strncmp(p, "To:", 3) == 0) {
421 p += 3;
>>> CID 641203: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
422 SKIP_WHITESPACE(p);
423 char* tp = strchr(p, QWK_NEWLINE); /* chop off at first CR */
424 if (tp != NULL)
425 *tp = 0;
426 SAFECOPY(to, p);
427 p += strlen(p) + 1;

** CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1960 in dns_blacklisted(int, const char *, xp_sockaddr *, char *, char *, char *)()


_____________________________________________________________________________________________
*** CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1960 in dns_blacklisted(int, const char *, xp_sockaddr *, char *, char *, char *)()
1954 continue;
1955
1956 sprintf(list, "%.100s", p);
1957
1958 /* terminate */
1959 tp = p;
>>> CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1960 FIND_WHITESPACE(tp);
1961 *tp = 0;
1962
1963 found = rblchk(sock, prot, addr, p);
1964 }
1965 fclose(fp);

** CID 641201: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 1185 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 1195 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 975 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 1202 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()


_____________________________________________________________________________________________
*** CID 641201: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 1185 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1179 break;
1180 }
1181
1182 /* Get destination user address */
1183 if ((p = strrchr(rcpt_list[rcpt_count], '<')) != NULL) {
1184 p++;
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1185 SKIP_WHITESPACE(p);
1186 SAFECOPY(addr, p);
1187 p = strrchr(addr, '>');
1188 if (p == NULL) {
1189 bprintf(text[InvalidNetMailAddr], rcpt_list[rcpt_count]);
1190 break;
/netmail.cpp: 1195 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1189 bprintf(text[InvalidNetMailAddr], rcpt_list[rcpt_count]);
1190 break;
1191 }
1192 *p = 0;
1193 } else {
1194 p = rcpt_list[rcpt_count];
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1195 SKIP_WHITESPACE(p);
1196 SAFECOPY(addr, p);
1197 }
1198 truncsp(addr);
1199
1200 /* Get destination user name */
/netmail.cpp: 975 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
969 bprintf(text[InvalidNetMailAddr], p);
970 continue;
971 }
972 while (at > p && *at > ' ')
973 at--;
974 p = at;
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
975 SKIP_WHITESPACE(p);
976 uint16_t net_type = smb_netaddr_type(p);
977 if (net_type != NET_INTERNET) {
978 bprintf(text[InvalidNetMailAddr], p);
979 break;
980 }
/netmail.cpp: 1202 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1196 SAFECOPY(addr, p);
1197 }
1198 truncsp(addr);
1199
1200 /* Get destination user name */
1201 p = rcpt_list[rcpt_count];
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1202 SKIP_WHITESPACE(p);
1203 SAFECOPY(name, p);
1204 p = strrchr(name, '<');
1205 if (!p)
1206 p = strrchr(name, '@');
1207 if (!p)

** CID 641200: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 1534 in ftpalias()
/ftpsrvr.c: 1547 in ftpalias()


_____________________________________________________________________________________________
*** CID 641200: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 1534 in ftpalias()
1528
1529 while (!feof(fp)) {
1530 if (!fgets(line, sizeof(line), fp))
1531 break;
1532
1533 p = line; /* alias */
>>> CID 641200: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1534 SKIP_WHITESPACE(p);
1535 if (*p == ';') /* comment */
1536 continue;
1537
1538 tp = p; /* terminator */
1539 FIND_WHITESPACE(tp);
/ftpsrvr.c: 1547 in ftpalias()
1541 *tp = 0;
1542
1543 if (stricmp(p, alias)) /* Not a match */
1544 continue;
1545
1546 p = tp + 1; /* filename */
>>> CID 641200: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1547 SKIP_WHITESPACE(p);
1548
1549 tp = p; /* terminator */
1550 FIND_WHITESPACE(tp);
1551 if (*tp)
1552 *tp = 0;

</pre>

<p>
<a href="https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
</p>

<p>Best regards,</p>
<p>The Coverity Scan Admin Team</p>
<img class="logo" width="140" src="https://scan.coverity.com/assets/BlackDuckLogo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" />
</body>
</html>
----==_mimepart_69679e3a9f33a_26617a2afbc97ad9ac59811--

--- SBBSecho 3.34-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)